search

gludington / conditional-visibility

a FoundryVTT module to hide tokens from some players, but not from others
4 stars 16 forks source link

Not compible with module "DAE" #23

Open mech-tools opened 4 years ago

mech-tools commented 4 years ago

Hello,

Thx for this great module. It seems to be incompatible with DAE : https://gitlab.com/tposney/dae

"Invisibility" status effect icon doesn't show up in the token HUD when both modules are activated.

FVTT 0.7.5 DnD 0.98

gludington commented 4 years ago

I could reproduce this, but it may be a larger issue with 0.75 than with DAE specifically. It appears that 0.75 has changed the data structure behind statusEffects, such that the icons are not necessarily preloaded. When I loaded the icon separately and refreshed the page, it worked as it should. I will have to figure out a way to keep provide the correct data structure for each version.

gludington commented 4 years ago

Upon further review, DarkDinDon is correct. When DAE is enabled, the first element of the custom statusEffects is not present.

mech-tools commented 4 years ago

@gludington doesn't seem to work with the latest version or CUB either. Icons are here but token visibility do not change.

gludington commented 4 years ago

On the DAE issue, DAE's maintainer has been very helpful, and will be releasing a fix on that side which will restore the first element in the list. I will take a look at CUB, as well as I bring the module into full 0.75 compatibility

mech-tools commented 4 years ago

@gludington any news on the DAE side? Visibility icons are working but token visibility is not

mech-tools commented 4 years ago

@gludington seems that DAE is not issue anymore 😄 But with the latest version of CUB and FVTT 0.7.7 + 5e 1.1.1, it's not working either.