search

gludington / conditional-visibility

a FoundryVTT module to hide tokens from some players, but not from others
4 stars 16 forks source link

Moving a token that is hidden makes it visible #24

Open feltz916 opened 4 years ago

feltz916 commented 4 years ago

Pretty sure this started after 0.7.5 update.

Steps to repro:

gludington commented 4 years ago

It appears on token move, the rendering goes through a different code path altogether until the next time the token doing the seeing is touched, which means this module does not touch it. Will need to figure out where that separate drawing pipeline is, and see if it can be inserted at all.

gludington commented 4 years ago

0.75 introduced a different code path for moving tokens, such that monkeypatching it for a module could be dangerously brittle. Filed an issue for discussion at https://gitlab.com/foundrynet/foundryvtt/-/issues/3974

feltz916 commented 4 years ago

@gludington it looks like some support for this was put into 0.7.6 core, will that allow progress to be made?

gludington commented 4 years ago

Yes, it does, and I have been looking at it as time permits, though I may not be able to fully commit until the weekend. If you are interested/able to install from and test a pre-release manifest URL, I may be able to place a work in progress tomorrow after work.

Avitale34 commented 3 years ago

Still having this issue :( any chance of fix? I love using this module!

OmnesPotens commented 3 years ago

@gludington This seems to be happening with the "In Darkness" condition as well.

Foundry version: 0.7.9 5e Version: 1.2.0

feltz916 commented 3 years ago

any updates to this issue?

ArdonDaros commented 3 years ago

This problem is also manifest with PF1 system, running the latest stable versions of both Foundry (0.7.9) and PF1 system: The token is correctly hidden, but as soon as the affected token is moved, players are able to see it normally.