search

gludington / conditional-visibility

a FoundryVTT module to hide tokens from some players, but not from others
4 stars 16 forks source link

Invisible condition cannot be removed #38

Open Sebmaster777 opened 3 years ago

Sebmaster777 commented 3 years ago

I am using FVTT 0.7.9 and PF1e 0.76.11. When I select the invisible condition on a token, I can not remove it, even if I delete the token and replace it, or even if I disable the module entirely.

gludington commented 3 years ago

Can you attempt to remove it with the script macros included in the compendium?

Sebmaster777 commented 3 years ago

Using the toggle invisibility macro removes it for a split second, before the condition and the icon returns pretty much immediately.

Nargath commented 3 years ago

I'm having this in a game of PF1 as well. Was messing with the settings, and applied Invisible to one of my players. Now I can't remove it, script or right-clicking the status counter on the token.

I can remove the effect by disabling the module, but then the character is stuck with this module's Invisible status counter permanently on

Tupsi commented 3 years ago

It might have something to do with the fact, that the macro induced "invisibility" seems to be something else then what you get when using the HUD, as I can produce TWO invisibility icons on my token when I first cast a spell which fires the invis via a ConditionalVisibility.setCondition(canvas.tokens.controlled, 'invisible', true) and then click on the HUD an apply it again. I am using dnd5e here and not PF1, but the problem seems the same.

And now I am stuck with a token unable to remove it as well, interesting.

Just tried it on a fresh token and just applying true and then false again plain in the console. That is working as intended (meaning the icon disappear).

Using it inside a macro from a spell (with ItemMacro feature from midi-qol) broke it here though, ending in the permanent invisibilty tagged to the actor.

btw, the whole EFFECT is gone, meaning even though the character still has the icon in the HUD the token itself acts visible again, meaning others can see it.

Interstingly enough, only the macro part seems broken now here. I can still apply the invis effect manually over the HUD (getting a 2nd invis icon as described above), but NOT with another call of the macro method.

Could this be related to the hide problem I reported in #47 ? It seems that the HUD and macro calls only appear to create the same effect, but underneath you do two different things.

Tupsi commented 3 years ago

ok, that sticking icon fixed itself with a simple F5 reload, sorry for that.

I got it working now, with assigning it to a DAE directly instead of trying to do it in the ItemMacro.