search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: nodejs=>18 compatibility #100

Closed mariobuikhuizen closed 1 year ago

mariobuikhuizen commented 1 year ago

Fixes: #99

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0ebf87d) 50.00% compared to head (d16f038) 50.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #100 +/- ## ======================================= Coverage 50.00% 50.00% ======================================= Files 7 7 Lines 140 140 ======================================= Hits 70 70 Misses 70 70 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

maartenbreddels commented 1 year ago

@dhomeier we need an older ubuntu image (20.02 should do) to run the 3.6 tests. Do you know how to do that?

maartenbreddels commented 1 year ago

lets merge this for now, and fix 36 later.

dhomeier commented 1 year ago

@dhomeier we need an older ubuntu image (20.02 should do) to the 3.6 tests. Do you know how to do that?

@mariobuikhuizen I think


        - linux: py36-test
          runs-on: ubuntu-20.02

should do the trick, but I believe we just dropped py36 and py37 before delving further into this.