Fix parsing of D3 color strings for color maps

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy

MIT License

19 stars 13 forks source link

Fix parsing of D3 color strings for color maps #26

Closed jsub1 closed 4 years ago

jsub1 commented 4 years ago

The D3 color scale was not returning colors as hex strings but in a different form (e.g. "rgb(50, 255, 30)"). This PR adds a helper function to the update_colormap to parse both hex strings and the above rgb strings. This is part of issue https://github.com/glue-viz/glue-jupyter/issues/76.

maartenbreddels commented 4 years ago

Hey, missed this PR, thanks for your patience, looks good!