glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy

MIT License

19 stars 13 forks source link

Use Jupyterlab3/Federated Extension System #35

Closed maartenbreddels closed 3 years ago

maartenbreddels commented 3 years ago

This avoids users having to build/use nodejs for JLab3

maartenbreddels commented 3 years ago

@astrofrog could you take a look at this, the failure is because for some reason the pyproject.toml is not respected, it should install jupyter lab which is not part of the build process.

astrofrog commented 3 years ago

Yes will look shortly!

astrofrog commented 3 years ago

@maartenbreddels - I think the CI should be fixed now, but let's see. At least it should be fixed locally.

astrofrog commented 3 years ago

I also removed your workaround commit

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (d29e9af) into master (b1241ac) will decrease coverage by 4.82%. The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   65.88%   61.05%   -4.83%     
==========================================
  Files           5        5              
  Lines          85       95      +10     
==========================================
+ Hits           56       58       +2     
- Misses         29       37       +8

Impacted Files	Coverage Δ
bqplot_image_gl/__init__.py	`35.71% <20.00%> (-39.29%)`	:arrow_down:
bqplot_image_gl/_version.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1241ac...d29e9af. Read the comment docs.

astrofrog commented 3 years ago

Not sure what is going on with the coverage but I think we can ignore for now

maartenbreddels commented 3 years ago

@astrofrog the last two commits I don't understand:

ci: add setup.py to manifest, unclear why
ci: jupyter_packaging everywhere

I don't think they should be there, could you take a look?

astrofrog commented 3 years ago

Will take a look tomorrow morning!

astrofrog commented 3 years ago

@maartenbreddels - there were two separate issues:

I think sdist is buggy in jupyter-packaging: https://github.com/jupyter/jupyter-packaging/pull/66 (I added a workaround here for now)
There was a typo in the jupyter-packaging name in pyproject.toml

Does this make sense?

astrofrog commented 3 years ago

Investigating a follow-up issue, think it should be fixable

maartenbreddels commented 3 years ago

Great, feel free to squash some commits if that cleans it up.

astrofrog commented 3 years ago

Wait actually I think they just released a version of jupyter-packaging with the fox so I think we can remove the workaround and update the min pinned version in pyproject, will push a commit shortly