search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: if no next interact was present, we would not get events #47

Closed maartenbreddels closed 3 years ago

maartenbreddels commented 3 years ago

This was because the display:none caused us to not have any events. The reason to add this is to not 'eat' mouse events from the 'next' interact. However, a better solution is to have the 'next', be added second in the DOM.

Fixes https://github.com/glue-viz/glue-jupyter/pull/213 for when next is set to None

codecov[bot] commented 3 years ago

Codecov Report

Merging #47 (9fcf3ca) into master (e6a1099) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   58.00%   58.00%           
=======================================
  Files           5        5           
  Lines         100      100           
=======================================
  Hits           58       58           
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6a1099...9fcf3ca. Read the comment docs.

maartenbreddels commented 3 years ago

Some cleanups and namespaced events solves all issues for glue-viz/glue-jupyter#213