glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

feat: add LinesGL Mark #58

Closed maartenbreddels closed 3 years ago

maartenbreddels commented 3 years ago

Does not have feature parity yet with bqplot.Lines. Supports

To be feature complete for glue-jupyter, we also need line width.

codecov[bot] commented 3 years ago

Codecov Report

Merging #58 (327103b) into master (bcde02d) will increase coverage by 5.38%. The diff coverage is 100.00%.

:exclamation: Current head 327103b differs from pull request most recent head 6b7e58e. Consider uploading reports for the commit 6b7e58e to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   50.00%   55.38%   +5.38%     
==========================================
  Files           6        7       +1     
  Lines         116      130      +14     
==========================================
+ Hits           58       72      +14     
  Misses         58       58              
Impacted Files Coverage Δ
bqplot_image_gl/__init__.py 40.00% <100.00%> (+4.28%) :arrow_up:
bqplot_image_gl/linesgl.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcde02d...6b7e58e. Read the comment docs.

maartenbreddels commented 3 years ago

This closes https://github.com/spacetelescope/jdaviz/issues/461 To compare, this 300k line segment runs about 0.1 fps using svg (bqplot.Lines) and using LinesGL runs quite smooth at ~12 fps under the profiler in chrome (the gif actually doesn't do it justice): linesg-after

maartenbreddels commented 3 years ago

@astrofrog I'm gonna merge this so this can be tested with https://github.com/glue-viz/glue-jupyter/pull/227 . This only adds a new feature, so totally backwards compatible.