search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: wait for view promises to give them time to create the DOM #61

Closed maartenbreddels closed 3 years ago

maartenbreddels commented 3 years ago

Some views such as https://github.com/bqplot/bqplot/blob/1c3c0abb474f4ccd0bbf4620f3a86c0d6c13454b/js/src/Figure.ts#L100 wait for the displayed and layoutPromise before creating DOM elements. We now wait for these so we don't query the DOM before they are created.

codecov[bot] commented 3 years ago

Codecov Report

Merging #61 (b1a0f57) into master (5d85a27) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files           7        7           
  Lines         130      130           
=======================================
  Hits           72       72           
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d85a27...b1a0f57. Read the comment docs.