search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: do not cull lines #64

Closed maartenbreddels closed 3 years ago

maartenbreddels commented 3 years ago

Since we modify the coordinates in the shaders (using scales), the coordinates for threejs can mislead it to think it's outside the frustum/viewport.

Fixes the issues described in https://github.com/glue-viz/glue-jupyter/pull/227

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (a7767a8) into master (9a43c64) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files           7        7           
  Lines         130      130           
=======================================
  Hits           72       72           
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a43c64...a7767a8. Read the comment docs.