search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: avoid duplicate ids in multiple threejs modules #66

Closed maartenbreddels closed 3 years ago

maartenbreddels commented 3 years ago

In the case where bqplot's threejs and our threejs are used, we can have colliding id's, which leads to wrong cache hits interally in threejs.

This caused the scatter plot in https://github.com/glue-viz/glue-jupyter/blob/master/notebooks/Astronomy/W5/W5%20Tutorial.ipynb to not show up the first time.

codecov[bot] commented 3 years ago

Codecov Report

Merging #66 (944f7a4) into master (a6c89f3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files           7        7           
  Lines         130      130           
=======================================
  Hits           72       72           
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6c89f3...944f7a4. Read the comment docs.