glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: MouseInteraction would remove all listeners in .off #80

Closed maartenbreddels closed 2 years ago

maartenbreddels commented 2 years ago

This caused 1 MouseInteraction that would be removed to remove the event listeners of all other MouseInteractions.

Fixes the issue @kecnry mentioned in https://github.com/spacetelescope/jdaviz/pull/1013 because the domain would not be updated any more.

codecov[bot] commented 2 years ago

Codecov Report

Merging #80 (37a0612) into master (a6c89f3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files           7        7           
  Lines         130      130           
=======================================
  Hits           72       72           
  Misses         58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6c89f3...37a0612. Read the comment docs.