Closed maartenbreddels closed 2 years ago
Merging #88 (4a3b64f) into master (03c4510) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 55.38% 55.38%
=======================================
Files 7 7
Lines 130 130
=======================================
Hits 72 72
Misses 58 58
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2b54101...4a3b64f. Read the comment docs.
@astrofrog it seems Py36 on CI it failing, I'm not sure how this CI setup works, maybe you've seen this before?
@maartenbreddels - let's just drop Python 3.6? glue-jupyter requires >=3.7
I agree
(from mobile phone)
Op di 19 apr. 2022 18:29 schreef Thomas Robitaille @.***
:
@maartenbreddels https://github.com/maartenbreddels - let's just drop Python 3.6? glue-jupyter requires >=3.7
— Reply to this email directly, view it on GitHub https://github.com/glue-viz/bqplot-image-gl/pull/88#issuecomment-1102853196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPEPMF3PXC3SA7V2KCADLVF3NONANCNFSM5TY57F3A . You are receiving this because you were mentioned.Message ID: @.***>
GH Actions still offer 3.6 on Windows, but in #89 that's then failing on a UTF-8 read. I left the linux-py36 there for the moment as ipywidgets and bqplot in principle still support 3.6, but have a look over there which envs should be kept in the end @maartenbreddels.
As said in #89, this is already an improvement, thanks Derek!
This will blend the line color with the background color/line. cc @kecnry