search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

Fix visibility toggle in LinesGL #90

Closed rosteen closed 2 years ago

rosteen commented 2 years ago

Description

LinesGL wasn't respecting visibility toggling from the front end. In non-GL bqplot both the image and lines marks inherit this behavior from Marks, but it seems like here it isn't getting inherited properly, since there was already code to do this in imagegl.js. This adds the equivalent code to linesgl.js, although it would be more elegant to have them both inherit the behavior properly.

codecov[bot] commented 2 years ago

Codecov Report

Merging #90 (9450e19) into master (03c4510) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files           7        7           
  Lines         130      130           
=======================================
  Hits           72       72           
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b54101...9450e19. Read the comment docs.

maartenbreddels commented 2 years ago

perfect, thanks 👍 !