search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

BUG: Remove non-existing import #92

Closed pllim closed 2 years ago

pllim commented 2 years ago

Description

Jdaviz is unable to use the latest release.

----> 1 from ._version import version_info, __version__  # noqa
      3 from .imagegl import *  # noqa
      4 from .linesgl import *  # noqa

ImportError: cannot import name 'version_info' from 'bqplot_image_gl._version'

cc @maartenbreddels @rosteen @orifox

pllim commented 2 years ago

Looks like version_info was removed in f1fe0c6368c27c2d489a47499a15c042d1b8ae9f

codecov[bot] commented 2 years ago

Codecov Report

Merging #92 (6f16140) into master (8677a0e) will decrease coverage by 0.69%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   55.38%   54.68%   -0.70%     
==========================================
  Files           7        7              
  Lines         130      128       -2     
==========================================
- Hits           72       70       -2     
  Misses         58       58
Impacted Files Coverage Δ
bqplot_image_gl/__init__.py 40.00% <100.00%> (ø)
bqplot_image_gl/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b3b994...6f16140. Read the comment docs.

maartenbreddels commented 2 years ago

Ouch, sorry for that, will make a new release directly.

pllim commented 2 years ago

Thanks for the quick response!