search

glue-viz / bqplot-image-gl

Jupyter widget for displaying images with a focus on astronomy
MIT License
19 stars 13 forks source link

fix: ViewListener did not work with multiple frontends. #98

Closed maartenbreddels closed 2 years ago

maartenbreddels commented 2 years ago

A single frontend is not aware of other frontends, therefore we cannot mutate the view_data dict in the frontend. Instead, we send messages to the kernel to update or remote entries.

Fixes https://github.com/spacetelescope/jdaviz/issues/1567

codecov[bot] commented 2 years ago

Codecov Report

Merging #98 (9fe812d) into master (eff96d7) will decrease coverage by 4.68%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   54.68%   50.00%   -4.69%     
==========================================
  Files           7        7              
  Lines         128      140      +12     
==========================================
  Hits           70       70              
- Misses         58       70      +12
Impacted Files Coverage Δ
bqplot_image_gl/viewlistener.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.