search

glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Handle GWCS for specutils 2.0 compatibility #100

Open rosteen opened 4 months ago

rosteen commented 4 months ago

Adding better handling of GWCS in the Spectrum1D handler. Opening as draft since this may need a couple other changes/additions, and because it shouldn't be merged until specutils 2.0 is ready for release. I'll also add some test coverage for the new code.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 21.95122% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 86.73%. Comparing base (aa305d7) to head (def40d3). Report is 3 commits behind head on main.

:exclamation: Current head def40d3 differs from pull request most recent head 262e98d. Consider uploading reports for the commit 262e98d to get more accurate results

Files Patch % Lines
glue_astronomy/translators/spectrum1d.py 21.95% 32 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== - Coverage 96.68% 86.73% -9.96% ========================================== Files 18 16 -2 Lines 1448 1470 +22 ========================================== - Hits 1400 1275 -125 - Misses 48 195 +147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.