glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Ensure all desired attributes are returned by the data translators #20

Open rosteen opened 3 years ago

rosteen commented 3 years ago

This is intended to be a round-up/continuation of a few separate discussions:

Ensuring that all desired attributes are successfully ingested into a Glue data object and returned by the glue-astronomy translators may require work outside glue-astronomy, but I created this issue here since the discussion was initially motivated by changes needed in the data translators.

ibusko commented 3 years ago

Masks should also round-trip successfully, besides the uncertainty.

rosteen commented 3 years ago

Ah, I wasn't aware of PR 19 when I made this issue - it looks like that PR implements part of what is needed here (getting masks and uncertainty from a Spectrum1D object into the Glue data object).

nmearl commented 3 years ago

Mask cannot round-trip currently, because they are overridden by the subset masks created in glue.