glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Spectrum1D round-trip test #22

Open eteq opened 3 years ago

eteq commented 3 years ago

This PR is currently just a (non-functional) test for round-tripping behavior in Spectrum1D. Meant as a starting point for test-driven development regarding an issue I'm about to create

codecov[bot] commented 3 years ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (755874d) 96.92% compared to head (f806a8c) 96.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #22 +/- ## ========================================== + Coverage 96.92% 96.95% +0.02% ========================================== Files 18 18 Lines 1399 1411 +12 ========================================== + Hits 1356 1368 +12 Misses 43 43 ``` | [Impacted Files](https://app.codecov.io/gh/glue-viz/glue-astronomy/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_astronomy/translators/spectrum1d.py](https://app.codecov.io/gh/glue-viz/glue-astronomy/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdHJhbnNsYXRvcnMvc3BlY3RydW0xZC5weQ==) | `94.73% <100.00%> (+0.07%)` | :arrow_up: | | [...lue\_astronomy/translators/tests/test\_spectrum1d.py](https://app.codecov.io/gh/glue-viz/glue-astronomy/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdHJhbnNsYXRvcnMvdGVzdHMvdGVzdF9zcGVjdHJ1bTFkLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dhomeier commented 1 year ago

@eteq I have rebased this and committed my proposed solution from https://github.com/glue-viz/glue-astronomy/issues/23#issuecomment-1441114343 for an initial implementation.