search

glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 13 forks source link

Add meta data on spectral cube translation #26

Closed nmearl closed 4 years ago

nmearl commented 4 years ago

Meta data included in the SpectralCube translation to a Glue Data object is stored, but not added when the data is translated back to a SpectralCube. This PR includes the meta data information on translation.

codecov[bot] commented 4 years ago

Codecov Report

Merging #26 into master will increase coverage by 0.58%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   96.64%   97.22%   +0.58%     
==========================================
  Files          13       13              
  Lines         924      974      +50     
==========================================
+ Hits          893      947      +54     
+ Misses         31       27       -4
Impacted Files Coverage Δ
glue_astronomy/translators/spectral_cube.py 100.00% <ø> (ø)
..._astronomy/translators/tests/test_spectral_cube.py 100.00% <100.00%> (ø)
glue_astronomy/translators/spectrum1d.py 97.22% <0.00%> (-2.78%) :arrow_down:
glue_astronomy/translators/ccddata.py 100.00% <0.00%> (ø)
...lue_astronomy/translators/tests/test_spectrum1d.py 100.00% <0.00%> (ø)
...onomy/io/spectral_cube/tests/test_spectral_cube.py 100.00% <0.00%> (+14.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebc0737...23b9720. Read the comment docs.