search

glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Add back use of SpectralCoordinate to wrap GWCS for now #45

Closed astrofrog closed 2 years ago

astrofrog commented 2 years ago

I decided to revert this change for now - should fix https://github.com/spacetelescope/jdaviz/issues/837 hopefully. @pllim can you confirm? (will merge this anyway once ready as it fixes another issue but just want to make sure it also fixes https://github.com/spacetelescope/jdaviz/issues/837)

codecov[bot] commented 2 years ago

Codecov Report

Merging #45 (728a904) into main (91a2013) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   94.21%   94.22%   +0.01%     
==========================================
  Files          15       15              
  Lines        1123     1126       +3     
==========================================
+ Hits         1058     1061       +3     
  Misses         65       65
Impacted Files Coverage Δ
glue_astronomy/translators/spectrum1d.py 87.58% <100.00%> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91a2013...728a904. Read the comment docs.

pllim commented 2 years ago

I can't confirm till next week...