glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Annulus region support #49

Closed pllim closed 1 year ago

pllim commented 2 years ago

There is a regions.CircleAnnulusPixelRegion but there does not appear to be an easy way for Glue to connect to it.

In an interactive workflow, a user would first define the outer circle (a Glue subset), the inner circle (another Glue subset), and then subtract them. Given everything was done interactively, there are two main problems that would prevent a robust translation:

  1. In some cases (especially if there is a weird aspect ratio or distortion in WCS), the circle drawn is translated into ellipse Subset shape.
  2. Inner circle may not share the exact center position as the outer circle, as they are both manually drawn on the screen.

So, how does one translate an imperfectly drawn annulus into CircleAnnulusPixelRegion?

Also see: spacetelescope/jdaviz#898

🐱