search

glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Return NDData for GWCS #58

Closed pllim closed 2 years ago

pllim commented 2 years ago

Description

Return NDData for GWCS instead of crashing in CCDData.

This works around astropy/astropy#11727 and is a hacky version of #38.

cc @rosteen

codecov[bot] commented 2 years ago

Codecov Report

Merging #58 (e54b08c) into main (25d7711) will decrease coverage by 0.23%. The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.03%   95.80%   -0.24%     
==========================================
  Files          15       15              
  Lines        1136     1145       +9     
==========================================
+ Hits         1091     1097       +6     
- Misses         45       48       +3
Impacted Files Coverage Δ
glue_astronomy/translators/ccddata.py 94.33% <81.81%> (-5.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25d7711...e54b08c. Read the comment docs.

pllim commented 2 years ago

Re: Test failure -- I forgot to handle the case for wcs = None in a backward compatible way. The tests should pass now. Good catch and thanks for review!

pllim commented 2 years ago

casa job failure is unrelated.