glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

MNT: Modernize packaging, etc #64

Closed pllim closed 2 years ago

pllim commented 2 years ago

I could not run tests locally, then I realized the packaging state of this package is way outdated. This pull request is to:

Out of scope:

codecov[bot] commented 2 years ago

Codecov Report

Merging #64 (2c93f45) into main (7f3229d) will increase coverage by 0.32%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   95.80%   96.13%   +0.32%     
==========================================
  Files          15       15              
  Lines        1145     1139       -6     
==========================================
- Hits         1097     1095       -2     
+ Misses         48       44       -4     
Impacted Files Coverage Δ
...onomy/io/spectral_cube/tests/test_spectral_cube.py 89.18% <84.21%> (+3.47%) :arrow_up:
glue_astronomy/__init__.py 100.00% <100.00%> (+28.57%) :arrow_up:
...lue_astronomy/translators/tests/test_spectrum1d.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f3229d...2c93f45. Read the comment docs.

pllim commented 2 years ago

@dhomeier , this PR should be uncontroversial?

astrofrog commented 2 years ago

I'll investigate the CASA failures separately

pllim commented 2 years ago

Whoops, @dhomeier , this PR was already merged.

dhomeier commented 2 years ago

Ah, seems the second pair of eyes was already faster than the first! Should not keep my review tabs open over night!