glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Expand Region Translator #8

Closed jsub1 closed 4 years ago

jsub1 commented 4 years ago

This PR adds support for translating more ROI subsets, non-ROI subsets, and compound subsets into astropy regions.

codecov[bot] commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.62%. The diff coverage is 98.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   97.54%   98.17%   +0.62%     
==========================================
  Files          13       13              
  Lines         571      877     +306     
==========================================
+ Hits          557      861     +304     
- Misses         14       16       +2
Impacted Files Coverage Δ
glue_astronomy/translators/tests/test_regions.py 100% <100%> (ø) :arrow_up:
glue_astronomy/translators/regions.py 94.59% <95.6%> (+16.81%) :arrow_up:
glue_astronomy/translators/tests/test_ccddata.py 97.67% <0%> (-2.33%) :arrow_down:
glue_astronomy/spectral_coordinates.py 93.33% <0%> (-0.42%) :arrow_down:
..._astronomy/translators/tests/test_spectral_cube.py 100% <0%> (ø) :arrow_up:
...lue_astronomy/translators/tests/test_spectrum1d.py 100% <0%> (ø) :arrow_up:
glue_astronomy/translators/ccddata.py 100% <0%> (ø) :arrow_up:
glue_astronomy/translators/spectrum1d.py 100% <0%> (ø) :arrow_up:
glue_astronomy/translators/spectral_cube.py 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64fac15...5055119. Read the comment docs.

jsub1 commented 4 years ago

Force push was to re-trigger tests after #9