Closed astrofrog closed 1 year ago
Is it a concern that the CI fails here?
Base: 96.99% // Head: 97.12% // Increases project coverage by +0.13%
:tada:
Coverage data is based on head (
7be8779
) compared to base (8d2a3e4
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I tried this out at https://github.com/spacetelescope/jdaviz/pull/1968 but now it fails with an even more obscure error:
AttributeError: 'numpy._ArrayFunctionDispatcher' object has no attribute '__code__'
https://github.com/spacetelescope/jdaviz/actions/runs/3959079839/jobs/6781436962
spectrum1d test was still expecting the old, incorrect shape.
Oh wait... glue-astronomy==0.5.1
... I think I have to remove pin because I am trying to install it from fork branch that has no tags. Hold on.
The pixel <-> world methods should return single scalars/arrays not tuples in order to be APE-14-compliant.