search

glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 13 forks source link

Fix world_axis_units for SpectralCoordinates #87

Closed astrofrog closed 1 year ago

astrofrog commented 1 year ago

This was an oversight and is needed for https://github.com/spacetelescope/jdaviz/pull/2048 to work properly

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21 :tada:

Comparison is base (71ded78) 97.12% compared to head (2125340) 97.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== + Coverage 97.12% 97.34% +0.21% ========================================== Files 18 18 Lines 1324 1355 +31 ========================================== + Hits 1286 1319 +33 + Misses 38 36 -2 ``` | [Impacted Files](https://codecov.io/gh/glue-viz/glue-astronomy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_astronomy/spectral\_coordinates.py](https://codecov.io/gh/glue-viz/glue-astronomy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvc3BlY3RyYWxfY29vcmRpbmF0ZXMucHk=) | `100.00% <100.00%> (ø)` | | | [glue\_astronomy/tests/test\_spectral\_coordinates.py](https://codecov.io/gh/glue-viz/glue-astronomy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdGVzdHMvdGVzdF9zcGVjdHJhbF9jb29yZGluYXRlcy5weQ==) | `100.00% <100.00%> (ø)` | | | [glue\_astronomy/translators/tests/test\_nddata.py](https://codecov.io/gh/glue-viz/glue-astronomy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdHJhbnNsYXRvcnMvdGVzdHMvdGVzdF9uZGRhdGEucHk=) | `98.56% <0.00%> (+0.14%)` | :arrow_up: | | [glue\_astronomy/translators/nddata.py](https://codecov.io/gh/glue-viz/glue-astronomy/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdHJhbnNsYXRvcnMvbmRkYXRhLnB5) | `95.37% <0.00%> (+2.81%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pllim commented 1 year ago

Thanks! With this out of the way, now I have https://github.com/glue-viz/glue/pull/2296/files#r1123283337