search

glue-viz / glue-astronomy

Plugin to add astronomy-specific functionality to glue
https://glue-astronomy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Added translator for `CircleAnnulusPixelRegion` #90

Closed pllim closed 1 year ago

pllim commented 1 year ago

This adds a one-way translator for CircleAnnulusPixelRegion.

Fix #49

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (478451f) 97.34% compared to head (6ca48f6) 97.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== + Coverage 97.34% 97.38% +0.03% ========================================== Files 18 18 Lines 1355 1375 +20 ========================================== + Hits 1319 1339 +20 Misses 36 36 ``` | [Impacted Files](https://codecov.io/gh/glue-viz/glue-astronomy/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_astronomy/translators/regions.py](https://codecov.io/gh/glue-viz/glue-astronomy/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdHJhbnNsYXRvcnMvcmVnaW9ucy5weQ==) | `96.66% <100.00%> (+0.33%)` | :arrow_up: | | [glue\_astronomy/translators/tests/test\_regions.py](https://codecov.io/gh/glue-viz/glue-astronomy/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV9hc3Ryb25vbXkvdHJhbnNsYXRvcnMvdGVzdHMvdGVzdF9yZWdpb25zLnB5) | `99.32% <100.00%> (+0.02%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pllim commented 1 year ago

I think Windows failure is transient download problem.

dhomeier commented 1 year ago

Just so I understand, the takes an accurately defined CircleAnnulusPixelRegion (with matching centres) as input, not the case of an imperfectly drawn one discussed in #49?

pllim commented 1 year ago

Yeah, I decided there is no point in guessing at an imperfect drawing. I am thinking of how to make this useful over at https://github.com/spacetelescope/jdaviz/pull/2164

dhomeier commented 1 year ago

I think Windows failure is transient download problem.

Yep, worked on re-run.

pllim commented 1 year ago

Thanks for the reviews! I believe I have addressed all the comments and added a test.

pllim commented 1 year ago

It is technically a new feature.

pllim commented 1 year ago

Thanks!

pllim commented 1 year ago

Is this released yet?