Closed pllim closed 1 year ago
Patch coverage: 60.00
% and project coverage change: -0.68
:warning:
Comparison is base (
dab988a
) 97.38% compared to head (8ce9ecc
) 96.71%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The patch coverage will be low because for a given glue version, it will go a specific route, and not the other one.
And you will see import error for dev tests until https://github.com/glue-viz/glue/pull/2403 is merged.
A maintainer can please rerun the failed jobs. They should pass now, hopefully.
Thanks for the merge! What is your timeline for release?
The glue side is released in 1.11.0, right?
@dhomeier , I don't know as https://github.com/glue-viz/glue/pull/2403 is not milestoned.
@dhomeier , does this mean we need to bump glue pin here?
The tests passed with 1.10.0 as well https://github.com/glue-viz/glue-astronomy/actions/runs/4962038394/jobs/8949618535 (I am afraid we missed to clean up the GLUE_LT_1_10_1
here!); obviously the new translator would not be available then, but probably no need to enforce version >= 1.11.0.
missed to clean up
Ooops... Do you want me to PR?
Dunno, does this require a bugfix release? Functionally it should not make a difference, as there probably will be no glue-core 1.10.1... Could still fix it for the next regular release.
Oh, in that case, I don't think it needs to change? Just a matter of pedantic?
Support new CircularAnnulusROI from glue-viz/glue#2403 (not yet merged when this PR is opened, so dev tests might fail, so we need to rerun that when it is merged upstream) by building on https://github.com/glue-viz/glue-astronomy/pull/90 .
Motivation: Instead of exposting the outer and inner circles separately in Jdaviz, we can now expose the proper annulus parameters by using this new ROI.
🐱