search

glue-viz / glue-medical

Experimental glue plugin for medical data
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Nifti misc improvements #7

Open AnnaBeers opened 7 years ago

AnnaBeers commented 7 years ago

This pull requests represents a few of QTIM lab's contributions to glue medical, especially pertaining to Nifti file formats and exporting subsets. More to come.

Remaining things to do:

astrofrog commented 7 years ago

@AndrewBeers - I had forgotten to commit utils.py, which I've done now - sorry!

astrofrog commented 7 years ago

There are some files that were added here that shouldn't be - specifically all the files in glue_medical.egg-info - can you remove these? By the way, I've just pushed a commit to master to add a .gitignore file (which was missing previously). I also fixed the DICOM tests. Could you rebase this branch?

EDIT: just remembered we had added a .gitignore file here, oops

astrofrog commented 6 years ago

@AndrewBeers - thanks for continuing work on this! Just so you know, since we last worked on this I've now added the ability to write custom subset mask importers/exporters:

http://glueviz.org/en/stable/customizing_guide/customization.html#custom-subset-mask-importers

This is different from the Data/Subset exporter:

http://glueviz.org/en/stable/customizing_guide/customization.html#custom-data-subset-exporters

because in the latter, the values of the subset should be exported, as opposed to the mask.