Closed victoriaono closed 1 year ago
Edit: As issues are resolved, I'll cross them out here.
@victoriaono Sorry it took me a while to look this over. Overall things are looking good, but I have some comments on how things stand right now:
pip install tox
tox -e codestyle
'0.35'
, so we need to be able to handle that. Currently the exporter gives an error if this is the caseOverall I like the idea of this implementation, this is a nice workaround to the lack of plotly support. I think it might be nice to have smoother color transitions, since the midpoint "seam" is often pretty obvious. This would require more than 1 line per point.
Edit: This isn't an issue because it actually matches the glue implementation! For some reason I had thought the glue colored lines were more continuous.
These have the same issue as the lines do when '0.35'
is the color
If a layer has vectors displayed, subsequent layers will not appear in the exported plotly graph
I think we discussed this a couple of weeks ago, but the vector arrows and positioning need some tweaking. It would be nice to support glue's vector origin property. One way to do this would be to apply the appropriate translation to the points used to create the vectors
Currently the exported image seems to only contain the first image layer, which is obviously a problem
We should have some sort of warning message if the selected colormap isn't supported by plotly
The contrast and bias settings in glue aren't used in the exporter
Let me know if you have any questions about any of these. Also, if I remember correctly you've got some other stuff lined up for the rest of the summer. If you don't think you have more time to work on this, just let me know and I can take things from here.
The updates here were repackaged into #18, #19, #20, #28, so this can be closed.
Description
This PR contains changes to the following viewers, adding features to plotly exporters not previously rendered:
Scatter 2D
Unresolved issues:
Scatter 3D
Unresolved issues:
New viewers
Histogram
Unresolved issues:
Image
Unresolved issues: