search

glue-viz / glue-plotly

Experimental plot.ly plugin for glue
BSD 3-Clause "New" or "Revised" License
2 stars 8 forks source link

Refactor image viewer export functionality #35

Closed Carifio24 closed 1 year ago

Carifio24 commented 1 year ago

This PR follows the same mold as the previous refactoring PRs, with the image viewer being the viewer of interest this time. The idea is to move the functionality of constructing the exported traces, layout configurations, etc. out to context-independent functions so that we can use them in other export contexts (e.g. the web exporter, glupyter?) in the future, while the export tool handles any Qt-viewer-specific stuff.

The image viewer is easily the most complicated one to export, and does some stuff with secondary axes, so adding this to the web exporter may be nontrivial and can wait for a future PR.

Carifio24 commented 1 year ago

codecov is complaining about coverage, but unit tests for these refactored functions are coming in a future PR, so I'm going to ignore that for now.