search

glue-viz / glue-vispy-viewers

3-d data viewers for glue based on VisPy
http://glueviz.org/en/stable/whatsnew/experimental_3d.html#experimental-3d
BSD 2-Clause "Simplified" License
25 stars 21 forks source link

Refactor 3D selection to use new glue infrastructure #301

Closed astrofrog closed 6 years ago

astrofrog commented 6 years ago

Since https://github.com/glue-viz/glue/pull/1522 has been merged, glue now includes the ability to represent 3D selections on a projected plane, so we can now make use of this to store 3D subsets much more efficiently (as an ROI + projection matrix) rather than as a boolean mask.

astrofrog commented 6 years ago

The flood fill still needs updating to not use mark_selected

astrofrog commented 6 years ago

This requires https://github.com/glue-viz/glue/pull/1616 to be merged and the new conda dev package to be build for glue-core.

astrofrog commented 6 years ago

This requires https://github.com/glue-viz/glue/pull/1617 to be merged to not have a performance regression for large cubes. But also we should make sure that we don't keep calling the subset state to_mask when changing e.g. the opacity of the cube. A further optimization we could do would be to switch between outline and data for subsets in the shader rather than reloading the data to the graphics card every time.