search

glue-viz / glue-vispy-viewers

3-d data viewers for glue based on VisPy
http://glueviz.org/en/stable/whatsnew/experimental_3d.html#experimental-3d
BSD 2-Clause "Simplified" License
25 stars 21 forks source link

don't read all data for a volume view #330

Closed ngoldbaum closed 6 years ago

ngoldbaum commented 6 years ago

This refactors the data access layer for the volume viewer to delay doing I/O until we need it. This means datasets (like yt data) that don’t look like a memory mapped array will lazily load subsets of the data.

astrofrog commented 6 years ago

@ngoldbaum - I investigated the test failure and I realized that it would be better to change the approach to avoid modifying the MultiVolumeVisual code (since it might be nice to move this upstream to VisPy in future) and have pushed a commit with an alternative approach. Could you try this out locally to check that it still works properly?

astrofrog commented 6 years ago

I tested this with glue-yt and it seemed to work, so I'll go ahead and merge - but just ping me on slack or open an issue here if you run into any issues!

ngoldbaum commented 6 years ago

I just tested and it seems to work over here. Sorry for taking a couple days to report back.