Closed dhomeier closed 2 years ago
Merging #371 (9034cd3) into master (7ce0c55) will increase coverage by
58.27%
. The diff coverage is100.00%
.:exclamation: Current head 9034cd3 differs from pull request most recent head 67a4ff8. Consider uploading reports for the commit 67a4ff8 to get more accurate results
@@ Coverage Diff @@
## master #371 +/- ##
===========================================
+ Coverage 22.21% 80.48% +58.27%
===========================================
Files 50 50
Lines 3885 3885
===========================================
+ Hits 863 3127 +2264
+ Misses 3022 758 -2264
Impacted Files | Coverage Δ | |
---|---|---|
glue_vispy_viewers/isosurface/multi_iso_visual.py | 53.33% <100.00%> (+42.22%) |
:arrow_up: |
glue_vispy_viewers/volume/volume_toolbar.py | 27.18% <0.00%> (+6.79%) |
:arrow_up: |
glue_vispy_viewers/common/selection_tools.py | 48.59% <0.00%> (+11.26%) |
:arrow_up: |
glue_vispy_viewers/common/tools.py | 70.88% <0.00%> (+16.45%) |
:arrow_up: |
...viewers/isosurface/tests/test_isosurface_viewer.py | 31.14% <0.00%> (+22.95%) |
:arrow_up: |
glue_vispy_viewers/utils.py | 50.94% <0.00%> (+24.52%) |
:arrow_up: |
glue_vispy_viewers/isosurface/layer_artist.py | 36.27% <0.00%> (+28.43%) |
:arrow_up: |
glue_vispy_viewers/common/vispy_data_viewer.py | 58.53% <0.00%> (+29.26%) |
:arrow_up: |
glue_vispy_viewers/scatter/scatter_viewer.py | 100.00% <0.00%> (+36.36%) |
:arrow_up: |
glue_vispy_viewers/conftest.py | 93.75% <0.00%> (+37.50%) |
:arrow_up: |
... and 38 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ce0c55...67a4ff8. Read the comment docs.
Marking this as ready as the vispy errors are not related to the Actions workflow. Trying to pin to vispy>=0.9.0,<0.9.1
does not bring much improvement either as there are still only 10 tests passing, and there seems to be no installable 0.9.0 for Python 3.10. Some new/additional failures with 0.10.0 and dev...
Description
Replace Azure via reusable workflows from https://github.com/OpenAstronomy/github-actions-workflows
vispy>0.9.1
failing due to https://github.com/vispy/vispy/pull/2227#issuecomment-953934640 since there is still an import in https://github.com/glue-viz/glue-vispy-viewers/blob/7ce0c55989eee9dc4056e5ce1547591cbaab86b6/glue_vispy_viewers/isosurface/multi_iso_visual.py#L45Including an attempt to replace
frag_dict
, which at least lets the tests run; no. of failures seems to be unchanged from vispy 0.9.0.