search

glue-viz / glue-vispy-viewers

3-d data viewers for glue based on VisPy
http://glueviz.org/en/stable/whatsnew/experimental_3d.html#experimental-3d
BSD 2-Clause "Simplified" License
25 stars 21 forks source link

Allow axis color to be changed during runtime. #372

Closed Carifio24 closed 1 year ago

Carifio24 commented 2 years ago

While doing some work on the glue-plotly 3D scatter exporter, I noticed that it's not possible to change the axis color of an AxesVisual3D during runtime. This is due to the fact that the color attribute of a vispy.visuals.line.LineVisual is a property without a setter. To fix this, this PR changes the axis color to be updated using set_data instead.

codecov[bot] commented 2 years ago

Codecov Report

Base: 22.21% // Head: 22.21% // No change to project coverage :thumbsup:

Coverage data is based on head (326fe73) compared to base (7ce0c55). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head 326fe73 differs from pull request most recent head c9b6763. Consider uploading reports for the commit c9b6763 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #372 +/- ## ======================================= Coverage 22.21% 22.21% ======================================= Files 50 50 Lines 3885 3885 ======================================= Hits 863 863 Misses 3022 3022 ``` | [Impacted Files](https://codecov.io/gh/glue-viz/glue-vispy-viewers/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_vispy\_viewers/common/axes.py](https://codecov.io/gh/glue-viz/glue-vispy-viewers/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV92aXNweV92aWV3ZXJzL2NvbW1vbi9heGVzLnB5) | `33.70% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Carifio24 commented 2 years ago

@astrofrog Changelog entry has been added

dhomeier commented 1 year ago

Sorry for the late reply @Carifio24 ; could you rebase this? – CI should be fixed now. You can simply enter the changelog entry as the full title of this PR.

Carifio24 commented 1 year ago

@dhomeier My commit added a 1.0.6 section to the changelog - should I reformat that to match the new style? Or just ditch the changelog commit? I don't want to muck up the auto-release action.

dhomeier commented 1 year ago

You could simply ditch it, as there would be some merge conflicts anyway – otherwise the entry auto-generated from the title would just duplicate it; can still remove that at release time (or mark this PR skip-changelog so no new entry will be generated). But an entry left here in CHANGES.md will probably not be sorted nicely into the 'New Features' section.

Carifio24 commented 1 year ago

@dhomeier I just ditched the changelog commit - that seems like the simpler option.

Carifio24 commented 1 year ago

Are the CI failures here real, or something from an old CI run? It looks like the logs have expired.