glue-viz / glue-vispy-viewers

3-d data viewers for glue based on VisPy
http://glueviz.org/en/stable/whatsnew/experimental_3d.html#experimental-3d
BSD 2-Clause "Simplified" License
25 stars 21 forks source link

Fix compatibility with PyQt6 and fix volume rendering with VisPy 0.11+ #376

Closed astrofrog closed 1 year ago

astrofrog commented 1 year ago

The 3D scatter viewer works with this in PyQt6. I'm having issues with volume rendering but trying to understand if that is a PyQt or VisPy (or both) issue.

codecov[bot] commented 1 year ago

Codecov Report

Base: 80.54% // Head: 80.50% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (ef08cc8) compared to base (ea215b2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ========================================== - Coverage 80.54% 80.50% -0.05% ========================================== Files 50 50 Lines 4035 4036 +1 ========================================== - Hits 3250 3249 -1 - Misses 785 787 +2 ``` | [Impacted Files](https://codecov.io/gh/glue-viz/glue-vispy-viewers/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_vispy\_viewers/volume/volume\_visual.py](https://codecov.io/gh/glue-viz/glue-vispy-viewers/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV92aXNweV92aWV3ZXJzL3ZvbHVtZS92b2x1bWVfdmlzdWFsLnB5) | `91.66% <100.00%> (-1.01%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.