search

glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Fix altUnit to work correctly on Windows WWT client #74

Closed astrofrog closed 4 years ago

astrofrog commented 4 years ago

Currently altUnit is inconsistent in the web client and the Windows client:

https://github.com/WorldWideTelescope/wwt-web-client/issues/248

Since there other bugs that mean the tour file can't load properly in the web client anyway, we should fix altUnit so that it is correct in the Windows client.

astrofrog commented 4 years ago

@pkgw - hopefully this will be temporary and won't end up in an actual glue-wwt release :) (the easiest fix on the web client side is to write out altUnit as strings)

codecov[bot] commented 4 years ago

Codecov Report

Merging #74 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   73.53%   73.71%   +0.18%     
==========================================
  Files          18       18              
  Lines         869      875       +6     
==========================================
+ Hits          639      645       +6     
  Misses        230      230
Impacted Files Coverage Δ
glue_wwt/viewer/tools.py 86.79% <100%> (+1.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 680ed8b...47fc877. Read the comment docs.