glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Add publishing workflow to GH Actions #86

Closed dhomeier closed 2 years ago

dhomeier commented 2 years ago

Description

Follow-up to #82 adding a publish_pure_python job.

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (cf34c3f) into main (101e94a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          18       18           
  Lines         860      860           
=======================================
  Hits          619      619           
  Misses        241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 101e94a...cf34c3f. Read the comment docs.

dhomeier commented 2 years ago

Any thoughts why the test_extras are not installing their PyQt dependencies? Might be because pip install QtPy by itself does not install a working backend, so maybe the install_requires explicitly need PyQt5 (or something like PyQt5 | PySide2)?

dhomeier commented 2 years ago

I suppose there is no subset of tests working without a backend, since the core package cannot even be imported? Shall I cut the tests until it is possible to set up a headless display in the publishing tests?

astrofrog commented 2 years ago

Yes can we just make the publish job be contingent on the main test matrix passing instead?

dhomeier commented 2 years ago

Oh; got the test_command working now (see comment in matrix).

Nonetheless having one job being contingent on another would in fact be useful (like for the minimal/extended test configurations), but I haven't found anything on how to do this so far.

astrofrog commented 2 years ago

I'll merge this for now, we can do the dependent stuff later