search

glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Fix incorrect attribute reference #87

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

This PR corrects a reference to self._viewer_state.dec_att (which doesn't exist) to self._viewer_state.lat_att in the table layer's _update_presentation method. This code path is reached when adding a layer to the viewer whose latitude attribute is incompatible with the current viewer settings.

codecov[bot] commented 2 years ago

Codecov Report

Merging #87 (f7c5c54) into main (101e94a) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          18       18           
  Lines         860      860           
=======================================
  Hits          619      619           
  Misses        241      241
Impacted Files Coverage Δ
glue_wwt/viewer/table_layer.py 76.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 101e94a...f7c5c54. Read the comment docs.