search

glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Add Python 3.11 and 3.12 CI envs #91

Closed dhomeier closed 7 months ago

dhomeier commented 1 year ago

Description

For good measure testing this with 3.11.0 as well.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.11%. Comparing base (9d482be) to head (44eae90). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## ======================================= Coverage 69.11% 69.11% ======================================= Files 18 18 Lines 1023 1023 ======================================= Hits 707 707 Misses 316 316 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhomeier commented 1 year ago

Upstream action on reproject and pywwt required; reproject might just need re-cythonising, no idea about pywwt.

astrofrog commented 1 year ago

reproject is a WIP

dhomeier commented 1 year ago

Yes; installing git+https://github.com/astropy/reproject.git works now.

dhomeier commented 1 year ago

pywwt and reproject updates have been released, so 3.11 can also be tested in normal envs now. I have removed the win-py37 run, which has started to fail on a Windows path error. @astrofrog I just noticed you are already dropping support for 3.7 in #94 – should I sync with that?

There are strange failures with the development version of glue-core, throwing errors like

../../.tox/py39-test-devdeps/lib/python3.9/site-packages/glue/app/qt/feedback.py:10: in from glue._deps import get_status_as_odict ../../.tox/py39-test-devdeps/lib/python3.9/site-packages/glue/_deps.py:227: in ('plugins', plugins()), ../../.tox/py39-test-devdeps/lib/python3.9/site-packages/glue/_deps.py:217: in plugins package = entry_point.dist.name E AttributeError: 'EntryPoint' object has no attribute 'dist'

e.g. https://github.com/glue-viz/glue-wwt/actions/runs/4331625068/jobs/7563583949#step:9:156

all 3.8 and 3.9 platforms, although glue's own tests are obviously still passing on 3.8.

astrofrog commented 7 months ago

@dhomeier - can you rebase/update this? Thanks!

dhomeier commented 7 months ago

@astrofrog, done. Should py312 be added now as well?

astrofrog commented 7 months ago

Yes please!

dhomeier commented 7 months ago

All passing!