Closed Carifio24 closed 11 months ago
Patch coverage: 45.03%
and project coverage change: -3.52%
:warning:
Comparison is base (
02379d0
) 71.55% compared to head (e0b83f8
) 68.04%. Report is 1 commits behind head on main.:exclamation: Current head e0b83f8 differs from pull request most recent head 051afd6. Consider uploading reports for the commit 051afd6 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Only Python 3.7 is failing with unrelated errors, which it looks like we're planning to drop in #94 anyways.
Showing grid coordinates (for all of the grids) is implemented in the web engine but not yet exposed to pywwt. I'm working on exposing the ability to change grid colors; I'll add grid text toggling as well
Marking this as draft as it anticipates the changes from https://github.com/WorldWideTelescope/pywwt/pull/354 and https://github.com/WorldWideTelescope/pywwt/pull/355, which aren't yet released but will be soon.
All of these features have now landed in pywwt
, so this should be ready to review.
@astrofrog I've added relevant UI updates to the Jupyter viewer as well. There are a lot of options now, so I set up the layout widget as an accordion whose sections match the tabs in the Qt version. I've also added a pin to the current pywwt
version.
Regarding the CI failure I think we should bump the minimum Python to 3.8, but can be done in a separate PR (@dhomeier could you take a look at updating this?)
This PR exposes grid and constellation settings from WWT - in particular, the ability to toggle whether constellation properties, constellation boundaries, and several grid types are visible. These toggles are exposing as options in the viewer state, with the updated options widget UI as below: