glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Expose grid and constellation settings #97

Closed Carifio24 closed 11 months ago

Carifio24 commented 1 year ago

This PR exposes grid and constellation settings from WWT - in particular, the ability to toggle whether constellation properties, constellation boundaries, and several grid types are visible. These toggles are exposing as options in the viewer state, with the updated options widget UI as below:

Screenshot from 2023-06-27 12-23-28

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 45.03% and project coverage change: -3.52% :warning:

Comparison is base (02379d0) 71.55% compared to head (e0b83f8) 68.04%. Report is 1 commits behind head on main.

:exclamation: Current head e0b83f8 differs from pull request most recent head 051afd6. Consider uploading reports for the commit 051afd6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== - Coverage 71.55% 68.04% -3.52% ========================================== Files 18 18 Lines 872 992 +120 ========================================== + Hits 624 675 +51 - Misses 248 317 +69 ``` | [Files Changed](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_wwt/viewer/jupyter\_viewer.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL2p1cHl0ZXJfdmlld2VyLnB5) | `0.00% <0.00%> (ø)` | | | [glue\_wwt/viewer/data\_viewer.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL2RhdGFfdmlld2VyLnB5) | `88.88% <100.00%> (+0.25%)` | :arrow_up: | | [glue\_wwt/viewer/options\_widget.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL29wdGlvbnNfd2lkZ2V0LnB5) | `96.92% <100.00%> (+1.80%)` | :arrow_up: | | [glue\_wwt/viewer/viewer\_state.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL3ZpZXdlcl9zdGF0ZS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Carifio24 commented 1 year ago

Only Python 3.7 is failing with unrelated errors, which it looks like we're planning to drop in #94 anyways.

Carifio24 commented 1 year ago

Showing grid coordinates (for all of the grids) is implemented in the web engine but not yet exposed to pywwt. I'm working on exposing the ability to change grid colors; I'll add grid text toggling as well

Carifio24 commented 1 year ago

Marking this as draft as it anticipates the changes from https://github.com/WorldWideTelescope/pywwt/pull/354 and https://github.com/WorldWideTelescope/pywwt/pull/355, which aren't yet released but will be soon.

Carifio24 commented 11 months ago

All of these features have now landed in pywwt, so this should be ready to review.

@astrofrog I've added relevant UI updates to the Jupyter viewer as well. There are a lot of options now, so I set up the layout widget as an accordion whose sections match the tabs in the Qt version. I've also added a pin to the current pywwt version.

astrofrog commented 11 months ago

Regarding the CI failure I think we should bump the minimum Python to 3.8, but can be done in a separate PR (@dhomeier could you take a look at updating this?)