glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Updates for glue-qt #98

Closed Carifio24 closed 1 year ago

Carifio24 commented 1 year ago

This PR will update glue-wwt to be compatible with the new glue-qt package, once we're ready for that (see https://github.com/glue-viz/glue/pull/2431). If the locations of things change, I will update here.

To do:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8c7eeda) 68.04% compared to head (2d1d707) 68.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #98 +/- ## ======================================= Coverage 68.04% 68.04% ======================================= Files 18 18 Lines 992 992 ======================================= Hits 675 675 Misses 317 317 ``` | [Files Changed](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz) | Coverage Δ | | |---|---|---| | [glue\_wwt/viewer/image\_style\_editor.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL2ltYWdlX3N0eWxlX2VkaXRvci5weQ==) | `63.63% <100.00%> (ø)` | | | [glue\_wwt/viewer/options\_widget.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL29wdGlvbnNfd2lkZ2V0LnB5) | `96.92% <100.00%> (ø)` | | | [glue\_wwt/viewer/qt\_data\_viewer.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL3F0X2RhdGFfdmlld2VyLnB5) | `94.11% <100.00%> (ø)` | | | [glue\_wwt/viewer/table\_style\_editor.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL3RhYmxlX3N0eWxlX2VkaXRvci5weQ==) | `81.81% <100.00%> (ø)` | | | [glue\_wwt/viewer/tests/test\_wwt\_widget.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL3Rlc3RzL3Rlc3Rfd3d0X3dpZGdldC5weQ==) | `97.47% <100.00%> (ø)` | | | [glue\_wwt/viewer/tools.py](https://app.codecov.io/gh/glue-viz/glue-wwt/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=glue-viz#diff-Z2x1ZV93d3Qvdmlld2VyL3Rvb2xzLnB5) | `50.94% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astrofrog commented 1 year ago

I've now released glue-qt v0.1.0 so you should be able to add that package as a dependency here (at least for the testing - we probably don't want it to be a compulsory runtime dependency in case glue-wwt is used in jupyter for instance).

Carifio24 commented 1 year ago

@astrofrog I've added glue-qt as a dependency for the test and qt install options (and also moved qtpy). I've also bumped the minimum Python version from 3.7 -> 3.8 to match glue-core, and swapped out the 3.7 CI for 3.11 as well. Let me know if you see any issues with those changes.