search

glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
740 stars 153 forks source link

Only install h5py for Python less than 3.11 #2341

Closed pllim closed 2 years ago

pllim commented 2 years ago

Description

As @astrofrog suggested in https://github.com/glue-viz/glue/issues/2340#issuecomment-1289518970

Temporarily workaround for #2340

pllim commented 2 years ago

Hmm... pkg_resources.extern.packaging.requirements.InvalidRequirement: Parse error at "'; python'": Expected string_end

dhomeier commented 2 years ago

I've added this configuration to the 3.11rc testing PR, and the important configurations are all passing without h5py as well, so that seems safe to remove from required deps: https://github.com/glue-viz/glue/actions/runs/3316670741/jobs/5478746701

pllim commented 2 years ago

@dhomeier , not sure what you mean but if you want to absorb this into your PR, feel free to do so!

dhomeier commented 2 years ago

I mean this PR does not have a real effect in the CI (other than confirming that the syntax is right), as we don't have any py311 envs in main yet. The last commit to #2321 already has added this, so those tests were running without h5py. Probably holding off that PR until there are 3.11.0 wheels for the dependencies, so you would not get a fully functional glue-core in your tests before that anyway.

pllim commented 2 years ago

Superseded by #2321