This PR adds arguments to facet_subsets to allow directly specifying subset styling and a colormap from that function call (as opposed to calling colorize_subsets after, as the dialog currently does. This PR also updates the subset faceting dialog to use the updated function signature, though it doesn't expose the styling options to the UI (though there's no reason that we couldn't).
I think there are a few use cases here. Subset faceting via the dialog should see a slight performance increase with a large number of subsets, since we no longer need another pass through to update colors. Dashboard-style applications could similarly benefit from this to avoid the quick re-rendering that inspired augmenting new_subset and new_subset_group. I could also see a tool or plugin that does automatic faceting benefiting from this as well.
This PR adds arguments to
facet_subsetsto allow directly specifying subset styling and a colormap from that function call (as opposed to callingcolorize_subsetsafter, as the dialog currently does. This PR also updates the subset faceting dialog to use the updated function signature, though it doesn't expose the styling options to the UI (though there's no reason that we couldn't).I think there are a few use cases here. Subset faceting via the dialog should see a slight performance increase with a large number of subsets, since we no longer need another pass through to update colors. Dashboard-style applications could similarly benefit from this to avoid the quick re-rendering that inspired augmenting
new_subsetandnew_subset_group. I could also see a tool or plugin that does automatic faceting benefiting from this as well.