glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
742 stars 153 forks source link

WIP: Add extended component #2373

Closed jfoster17 closed 1 year ago

jfoster17 commented 1 year ago

Pull Request Template

Description

Here is one approach to displaying many regions (e.g. regions-as-data) in glue (ala #2351). I've implemented this for the first place I wanted it, which is as a different kind of ScatterLayer in the ImageViewer.

The pieces are basically:

Major unfinished things

jfoster17 commented 1 year ago

Here are what the basic interactions look like: https://user-images.githubusercontent.com/3639698/223265425-c45a4d0e-74bf-4fba-a94e-a2fc914c3f87.mov

astrofrog commented 1 year ago

@jfoster17 this is very nice! It looks like this will need rebasing due to conflicts. Would you like me to review this yet at this point or are there things you still need to work on before a first review?

jfoster17 commented 1 year ago

There are still a few more things I need to fix/add before this is ready for review. I will try to keep it to the smallest amount required to be useful though, so that it doesn't get too large.

jfoster17 commented 1 year ago

I wanted to highlight 79e4fa57ec44c50977c4056d9ba3fbc2c9a3322b, because it opens (or increases?) the potential for malicious session files and deserves some consideration. If I'm going to represent regions as Shapely objects we need something like this to enable save/restore of sessions that bundle the data. This also solves #2330.

astrofrog commented 1 year ago

I'd rather not use allow_pickle if at all possible - is there any way we can serialize/deserialize the Shapely objects to strings?

astrofrog commented 1 year ago

As noted in https://github.com/glue-viz/glue/issues/2430, I will be splitting out Qt-related code into a separate repository - however that repository will have the same history as the present one here so it should be easy to split the Qt-specific parts of this PR into a separate PR to glue-qt. Sorry for the disruption!

jfoster17 commented 1 year ago

Closing in favor of #2442