search

glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
742 stars 153 forks source link

qtconsole 5.4.2 does not work #2382

Closed jfoster17 closed 1 year ago

jfoster17 commented 1 year ago

Describe the bug qtconsole 5.4.2 (released April 2, 2023) breaks the built-in terminal in glue.

To Reproduce Steps to reproduce the behavior such as:

  1. Install the latest glue, which will pull qtconsole 5.4.2 (at least if using pip)
  2. Open a terminal
  3. Enter any command or just hit return
  4. See the following error
Traceback (most recent call last):
  File "/Users/jfoster/mambaforge/envs/pancreas-spaceranger-dev/lib/python3.10/site-packages/qtconsole/base_frontend_mixin.py", line 138, in _dispatch
    handler(msg)
  File "/Users/jfoster/mambaforge/envs/pancreas-spaceranger-dev/lib/python3.10/site-packages/qtconsole/jupyter_widget.py", line 193, in _handle_execute_reply
    super()._handle_execute_reply(msg)
  File "/Users/jfoster/mambaforge/envs/pancreas-spaceranger-dev/lib/python3.10/site-packages/qtconsole/frontend_widget.py", line 468, in _handle_execute_reply
    if not self.kernel_client.iopub_channel.closed():
AttributeError: 'QtInProcessChannel' object has no attribute 'closed'

Additional context This is a known problem (https://github.com/jupyter/qtconsole/pull/575) and there is an open PR with qtconsole to fix, but perhaps we should pin the qtconsole version for now, or specify !=5.4.2?

We don't have a test that catches this kind of problem though