glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
740 stars 153 forks source link

Only force reference data change if message indicates that numerical values of data have changed #2385

Closed astrofrog closed 1 year ago

astrofrog commented 1 year ago

The original intent of the _reference_data_changed(force=True) call was for cases where the coordinate system is changed, but we don't need to always force an update in other situations that might cause _update_data to be called.

pllim commented 1 year ago

@kecnry , should probably test this against the unit conversion branch over at Jdaviz since I don't know if changing viewer unit should trigger this or not.

Sounds like we can ignore https://github.com/glue-viz/glue-jupyter/pull/350 ?