search

glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
742 stars 153 forks source link

Remove blanket np.seterr and only use it as needed as context manager #2395

Open pllim opened 1 year ago

pllim commented 1 year ago

Looks like this was added 12 years ago but is it wise to blanket ignore like this? What if it is masking real problems? I propose you only do this as context manager for the piece of code where it is actually needed.

https://github.com/glue-viz/glue/blob/d2adb6895514044d4b40fdf1f2c082ca92df6a4b/glue/core/roi.py#L12

astrofrog commented 1 year ago

Agree!