glue-viz / glue

Linked Data Visualizations Across Multiple Files

http://glueviz.org

Other

742 stars 153 forks source link

Fix filter logic when underlying data set is not visible #2408

Closed jfoster17 closed 1 year ago

jfoster17 commented 1 year ago

Fix Filtering and Underlying Data Not Visible

Description

PR #2392 introduced a bug wherein making the underlying table dataset not visible did not remove it from the table model and display. This PR adds tests for this behavior and fixes the problem.

A second PR to be posted shortly will fix the separate problem that under Qt6 you cannot re-enable a not-visible layer artist using the UI checkbox.

jfoster17 commented 1 year ago

Sorry, I made a garbage merge here. I'll just close this PR and open a new one!